diff options
| author | Serge Semin <fancer.lancer@gmail.com> | 2023-11-20 23:46:21 +0300 |
|---|---|---|
| committer | Serge Semin <fancer.lancer@gmail.com> | 2026-08-13 20:37:48 +0300 |
| commit | 7b4b0427822ebcfc5f727d292a959cbaae1432f5 (patch) | |
| tree | fbc03696bee95690fd71c24e41f6748da0d580de | |
| parent | 83ea1da5507595cf2452ac2772b78069565d5b7e (diff) | |
| download | linux-7b4b0427822ebcfc5f727d292a959cbaae1432f5.tar.gz linux-7b4b0427822ebcfc5f727d292a959cbaae1432f5.zip | |
net: pcs: xpcs: Stop overriding pause in xpcs_get_state_c37_sgmii()
The phylink_link_state->pause field can have some flags being pre-set
(i.e. MLO_PAUSE_AN) by the phylink core before it's passed to the
phylink_pcs_ops.pcs_get_state() callback. Moreover based on the
phylink_pcs_ops.pcs_get_state() kernel doc it is intended to update the
MLO_PAUSE_RX and MLO_PAUSE_TX flags state only. So drop zeroing out the
phylink_link_state->pause field from the xpcs_get_state_c37_sgmii() method
as pointless and potentially harmful.
Link: https://lore.kernel.org/netdev/ZTuvwnGZKEueGDwa@shell.armlinux.org.uk
Fixes: b97b5331b8ab ("net: pcs: add C37 SGMII AN support for intel mGbE controller")
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
| -rw-r--r-- | drivers/net/pcs/pcs-xpcs.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c index 86706a18c21e..3ccee6b5c56e 100644 --- a/drivers/net/pcs/pcs-xpcs.c +++ b/drivers/net/pcs/pcs-xpcs.c @@ -1060,7 +1060,6 @@ static int xpcs_get_state_c37_sgmii(struct dw_xpcs *xpcs, state->link = false; state->speed = SPEED_UNKNOWN; state->duplex = DUPLEX_UNKNOWN; - state->pause = 0; /* For C37 SGMII mode, we check DW_VR_MII_AN_INTR_STS for link * status, speed and duplex. |