kernel/git/stable/linux.git/drivers/crypto/atmel-ecc.c, branch master

crypto: atmel-ecc - drop redundant return variable

2026-08-10T08:20:20+00:00

In atmel_ecdh_generate_public_key(), drop the redundant return variable and return -EINVAL and 0 directly. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: atmel-ecc - simplify control flow in atmel_ecdh_set_secret

2026-08-10T08:20:20+00:00

Free the public key directly on I2C transaction failure and remove the free_public_key label to simplify the code. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: atmel-ecc - avoid stale fallback key after set_secret failure

2026-07-17T08:09:22+00:00

Clear ->do_fallback before decoding a new ECDH secret and enable it only after the software fallback accepts a caller-provided private key. This avoids using a stale fallback key should crypto_kpp_set_secret() fail. Fixes: 11105693fa05 ("crypto: atmel-ecc - introduce Microchip / Atmel ECC driver") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: atmel-ecc - reject hardware ECDH without a public key

2026-07-05T05:24:07+00:00

The hardware ECDH path in atmel_ecdh_compute_shared_secret() uses the private key stored in the device. However, the public key is cached only after atmel_ecdh_set_secret() successfully generated that private key for the current tfm. atmel_ecdh_generate_public_key() already rejects requests when no public key is cached. Add the same check to atmel_ecdh_compute_shared_secret() to prevent the device from using a private key that was not generated for the current tfm. Fixes: 11105693fa05 ("crypto: atmel-ecc - introduce Microchip / Atmel ECC driver") Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: atmel-ecc - drop unused curve id from atmel_ecdh_ctx

2026-07-05T05:23:20+00:00

->curve_id is only set once, but never used - remove it. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: atmel-ecc - clean up and improve ECDH comments

2026-07-05T05:22:35+00:00

Improve the kerneldoc for struct atmel_ecdh_ctx by removing the stale "unsupported curves" wording, since the device only supports a single curve (P-256), and move the set_secret() constraint to the description. In atmel_ecdh_set_secret(), clarify that the device generates the private key, and drop the redundant "only supports NIST P256" comment. In atmel_ecdh_done() and atmel_ecdh_generate_public_key(), clarify the truncation comments. Also note that a P-256 public key consists of two 32-byte coordinates in atmel_ecdh_compute_shared_secret(), and remove the unnecessary fall-through comment and other redundant comments. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: atmel-ecc - drop dead code in atmel_ecdh_max_size

2026-06-12T01:56:45+00:00

atmel_ecdh_init_tfm() always allocates ctx->fallback, so it is never NULL in atmel_ecdh_max_size(). Remove the dead code and return crypto_kpp_maxsize() directly. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: atmel-ecc - Use named initializers for struct i2c_device_id

2026-05-29T05:55:58+00:00

While being less compact, using named initializers allows to more easily see which members of the structs are assigned which value without having to lookup the declaration of the struct. And it's also more robust against changes to the struct definition. This patch doesn't modify the compiled array, only its representation in source form benefits. The former was confirmed with x86 and arm64 builds. Signed-off-by: Uwe Kleine-König (The Capable Hub) Signed-off-by: Herbert Xu

crypto: atmel-ecc - drop CONFIG_OF guard and of_match_ptr

2026-05-15T10:08:48+00:00

Drop the CONFIG_OF preprocessor guard and remove of_match_ptr() because OF matching is stubbed out when CONFIG_OF=n. Reformat atmel_ecc_dt_ids for consistency. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: atmel-ecc - replace min_t with min

2026-05-15T10:08:47+00:00

Use the simpler min() macro since the values are all unsigned and compatible. Signed-off-by: Thorsten Blum Reviewed-by: David Laight Signed-off-by: Herbert Xu