diff options
| author | Li Qiang <liq3ea@163.com> | 2021-05-15 20:03:58 -0700 |
|---|---|---|
| committer | Michael Roth <michael.roth@amd.com> | 2021-10-17 20:25:43 -0500 |
| commit | 6ae68dfd10e53466e341f8330e0c8f9f10bd5d54 (patch) | |
| tree | 1195d151398670aee2ae3f8a54a31bb90e4e442f | |
| parent | c5300b8a94105dee1c44ac49d2bb3b35412b5ae6 (diff) | |
| download | qemu-6ae68dfd10e53466e341f8330e0c8f9f10bd5d54.tar.gz qemu-6ae68dfd10e53466e341f8330e0c8f9f10bd5d54.zip | |
vhost-user-gpu: fix memory leak in vg_resource_attach_backing (CVE-2021-3544)
Check whether the 'res' has already been attach_backing to avoid
memory leak.
Fixes: CVE-2021-3544
Reported-by: Li Qiang <liq3ea@163.com>
virtio-gpu fix: 204f01b309 ("virtio-gpu: fix memory leak
in resource attach backing")
Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210516030403.107723-4-liq3ea@163.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit b9f79858a614d95f5de875d0ca31096eaab72c3b)
Signed-off-by: Michael Roth <michael.roth@amd.com>
| -rw-r--r-- | contrib/vhost-user-gpu/vhost-user-gpu.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-gpu/vhost-user-gpu.c index b5e153d0d6..0437e52b64 100644 --- a/contrib/vhost-user-gpu/vhost-user-gpu.c +++ b/contrib/vhost-user-gpu/vhost-user-gpu.c @@ -489,6 +489,11 @@ vg_resource_attach_backing(VuGpu *g, return; } + if (res->iov) { + cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC; + return; + } + ret = vg_create_mapping_iov(g, &ab, cmd, &res->iov); if (ret != 0) { cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC; |