summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Fernald <chfernal@microsoft.com>2026-07-22 09:36:09 -0700
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2026-09-02 17:34:24 +0000
commit2e53034f67fba2209468fdde33b6d0e0c24f767f (patch)
tree1cedb131bd02a7313bf7c6d2aff41b4193240551
parent84f131e38d62f97dae6298f613d3b41a7870c9b2 (diff)
downloadedk2-2e53034f67fba2209468fdde33b6d0e0c24f767f.tar.gz
edk2-2e53034f67fba2209468fdde33b6d0e0c24f767f.zip
MdeModulePkg: Print unknown error code instead of asserting
DumpUicCmdExecResult & DumpQueryResponseResult are called to dump the result of UIC commands after a failure. Depending on the nature of the failure, not all information may have been properly initialized. This is already handled in callers with existing retry logic, but the assert in the dump command can cause a crash in debug builds for due to hardware race conditions on first attempt. Signed-off-by: Chris Fernald <chfernal@microsoft.com>
-rw-r--r--MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c
index 6b433f18e9..c1b71ff946 100644
--- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c
+++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c
@@ -181,7 +181,7 @@ DumpUicCmdExecResult (
DEBUG ((DEBUG_VERBOSE, "UIC configuration command fails - DME_FAILURE\n"));
break;
default:
- ASSERT (FALSE);
+ DEBUG ((DEBUG_VERBOSE, "UIC configuration command fails - UNKNOWN_ERROR (0x%02x)\n", Result));
break;
}
} else {
@@ -192,7 +192,7 @@ DumpUicCmdExecResult (
DEBUG ((DEBUG_VERBOSE, "UIC control command fails - FAILURE\n"));
break;
default:
- ASSERT (FALSE);
+ DEBUG ((DEBUG_VERBOSE, "UIC control command fails - UNKNOWN_ERROR (0x%02x)\n", Result));
break;
}
}
@@ -241,7 +241,7 @@ DumpQueryResponseResult (
DEBUG ((DEBUG_VERBOSE, "Query Response with General Failure\n"));
break;
default:
- ASSERT (FALSE);
+ DEBUG ((DEBUG_VERBOSE, "Query Response with Unknown Error (0x%02x)\n", Result));
break;
}
}