diff options
| author | Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com> | 2026-08-19 11:00:30 +0530 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2026-08-31 11:45:00 -0500 |
| commit | 9db31edf92dde1f3c98008bd5f88e859d14324cc (patch) | |
| tree | 2c9a092569039584dd3d03dec4e5a031be2b829e /scripts/Makefile.thinlto | |
| parent | 0d8e2195bce6f08c1c53c5ef4d7347fe46418101 (diff) | |
| download | linux-next-9db31edf92dde1f3c98008bd5f88e859d14324cc.tar.gz linux-next-9db31edf92dde1f3c98008bd5f88e859d14324cc.zip | |
remoteproc: qcom_q6v5_pas: Fix error masking in qcom_pas_stop()
In qcom_pas_stop function, return value of qcom_pas_shutdown for pas_id
is overwritten by the return value of qcom_pas_shutdown for dtb_pas_id.
This causes errors seen on qcom_pas_shutdown failures for pas_id to be
masked to the caller. This might lead to issues where the memory regions
locked by PAS, as part of qcom_pas_auth_and_reset, are not released for
access by linux and rproc_coredump flow will end up accessing the locked
memory, leading to an access violation.
Fix this by using a separate variable for the dtb_pas_id shutdown call
and only overriding the main return value if the pas_id shutdown succeeded
but dtb_pas_id shutdown failed.
Fixes: 29814986b82e ("remoteproc: qcom_q6v5_pas: add support for dtb co-firmware loading")
Signed-off-by: Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260819-rproc_dtb_fix-v1-1-cb6be7f93bc9@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Diffstat (limited to 'scripts/Makefile.thinlto')
0 files changed, 0 insertions, 0 deletions
