diff options
| author | Pan Chuang <panchuang@vivo.com> | 2026-07-14 21:13:30 +0800 |
|---|---|---|
| committer | Thomas Gleixner <tglx@kernel.org> | 2026-07-15 08:40:22 +0200 |
| commit | 9023960b74ab32bef73273cfb5bff3b0b70d5ef8 (patch) | |
| tree | 11174c3a19a240def471d2444a0943ede1678af1 /drivers/irqchip | |
| parent | 5b4fa95e425b6699c5dac47650d7a6f7b4661263 (diff) | |
| download | linux-9023960b74ab32bef73273cfb5bff3b0b70d5ef8.tar.gz linux-9023960b74ab32bef73273cfb5bff3b0b70d5ef8.zip | |
irqchip: Remove redundant dev_err()/dev_err_probe()
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Radu Rendec <radu@rendec.net>
Link: https://patch.msgid.link/20260714131331.494902-1-panchuang@vivo.com
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-qcom-mpm.c | 4 | ||||
| -rw-r--r-- | drivers/irqchip/irq-renesas-rzt2h.c | 2 | ||||
| -rw-r--r-- | drivers/irqchip/irq-renesas-rzv2h.c | 4 |
3 files changed, 4 insertions, 6 deletions
diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c index 181320528a47..8c575d7ce8a1 100644 --- a/drivers/irqchip/irq-qcom-mpm.c +++ b/drivers/irqchip/irq-qcom-mpm.c @@ -464,10 +464,8 @@ static int qcom_mpm_probe(struct platform_device *pdev, struct device_node *pare ret = devm_request_irq(dev, irq, qcom_mpm_handler, IRQF_NO_SUSPEND, "qcom_mpm", priv); - if (ret) { - dev_err(dev, "failed to request irq: %d\n", ret); + if (ret) goto remove_domain; - } return 0; diff --git a/drivers/irqchip/irq-renesas-rzt2h.c b/drivers/irqchip/irq-renesas-rzt2h.c index e06264add3cc..9086fc3a2043 100644 --- a/drivers/irqchip/irq-renesas-rzt2h.c +++ b/drivers/irqchip/irq-renesas-rzt2h.c @@ -398,7 +398,7 @@ static int rzt2h_icu_request_irqs(struct platform_device *pdev, struct irq_domai ret = devm_request_irq(dev, virq, handler, 0, dev_name(dev), data ?: (void *)(uintptr_t)offset); if (ret) - return dev_err_probe(dev, ret, "Failed to request IRQ %u\n", offset); + return ret; } return 0; diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c index 971ac83eee90..1a4703a353e9 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -816,7 +816,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain ret = devm_request_irq(dev, virq, rzv2h_icu_swint_irq, 0, dev_name(dev), (void *)(uintptr_t)i); if (ret) - return dev_err_probe(dev, ret, "Failed to request int-ca55-%u IRQ\n", i); + return ret; } /* Unmask and clear all IP/CA55 error interrupts */ @@ -844,7 +844,7 @@ static int rzv2h_icu_setup_irqs(struct platform_device *pdev, struct irq_domain ret = devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_name(dev), rzv2h_icu_data); if (ret) - return dev_err_probe(dev, ret, "Failed to request icu-error-ca55 IRQ\n"); + return ret; return 0; } |