diff options
| author | Donggeun Yoo <donggeunyoo.kernel@gmail.com> | 2026-09-08 19:59:58 +0900 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-09-10 08:47:22 -0700 |
| commit | 6ca81bbc31cdc964e4b74d17b86215d4a810a56f (patch) | |
| tree | 0179c0ec9b498bdde3b83f0db783e424b5891b69 /scripts/basic/split-include.c | |
| parent | e1406330d70e56dd44fa6fbafc86e77e5c80c122 (diff) | |
| download | linux-6ca81bbc31cdc964e4b74d17b86215d4a810a56f.tar.gz linux-6ca81bbc31cdc964e4b74d17b86215d4a810a56f.zip | |
net: phy: dp83td510: handle the active-high LED polarity mode
dp83td510_led_polarity_set() only recognizes PHY_LED_ACTIVE_LOW, so
PHY_LED_ACTIVE_HIGH falls through to the default case and returns -EINVAL.
of_phy_led() propagates the error, of_phy_leds() drops the LEDs registered
so far and passes it on, and phy_probe() returns it. A device tree marking
a DP83TD510 LED as 'active-high', which leds/common.yaml allows and
ethernet-phy.yaml references for led@N nodes, thus leaves the mdio device
unbound, so phy_attach_direct() falls back to the genphy driver, which
cannot drive this 10BASE-T1L single-mode PHY, so the interface has no
usable link.
The callback initializes polarity to DP83TD510E_LED_POLARITY(index), which
is the active-high setting, so the request is already satisfied and only
the case label is missing.
Cc: stable@vger.kernel.org
Fixes: 5b281fe7e396 ("net: phy: dp83td510: introduce LED framework support")
Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260908105959.70453-3-donggeunyoo.kernel@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'scripts/basic/split-include.c')
0 files changed, 0 insertions, 0 deletions
