diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2026-08-21 07:49:16 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2026-09-07 07:22:19 -0700 |
| commit | 70c33e211b2b78830f76c908e5236b77ffde63a0 (patch) | |
| tree | 2132e5262dfd74d7f677f9c292df6088f711ae7f /scripts/basic | |
| parent | 06b7cf395b1fb652a50db39674a759658fbfba0d (diff) | |
| download | linux-70c33e211b2b78830f76c908e5236b77ffde63a0.tar.gz linux-70c33e211b2b78830f76c908e5236b77ffde63a0.zip | |
hwmon: (sht4x) Fix return value from heater_enable_store()
Sashiko reports:
The return value in heater_enable_store() causes an unexpected write
failure in user-space.
When the heater is successfully enabled, the function returns 0
instead of count:
drivers/hwmon/sht4x.c:heater_enable_store() {
...
data->heating_complete = jiffies + msecs_to_jiffies(heating_time_bound);
data->data_pending = true;
return 0;
}
Returning 0 signals to VFS that no bytes were processed. Standard
user-space tools will retry the write with the remaining bytes. On the
retry, time_before(jiffies, data->heating_complete) evaluates to true,
and the function immediately fails with -EBUSY.
Return count as expected to fix the problem.
Fixes: 0eed6fc3d2b9e ("hwmon: (sht4x): add heater support")
Cc: Antoni Pokusinski <apokusinski01@gmail.com>
Cc: Alessandro Zini <alessandro.zini@siemens.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Link: https://patch.msgid.link/20260821144916.2889031-2-linux@roeck-us.net
Diffstat (limited to 'scripts/basic')
0 files changed, 0 insertions, 0 deletions
