diff options
| author | David E. Garcia Porras <david.garcia@aheadcomputing.com> | 2026-08-18 15:00:21 -0600 |
|---|---|---|
| committer | Anup Patel <anup@brainfault.org> | 2026-09-03 13:27:45 +0530 |
| commit | d97cfb33ae1ac0d9eebce1a03c96497a1f8f4c67 (patch) | |
| tree | 7671e94c1364a6e3bb578a8380580d9b6a5377c8 /lib/sbi/sbi_pmu.c | |
| parent | 35511bc6ee1c9c17b6a89b44c52e2044bb51b979 (diff) | |
| download | opensbi-d97cfb33ae1ac0d9eebce1a03c96497a1f8f4c67.tar.gz opensbi-d97cfb33ae1ac0d9eebce1a03c96497a1f8f4c67.zip | |
lib: sbi_pmu: Return invalid param error for reserved event_idx bits
As per section 11.14 of the SBI specification (Function: Get PMU Event
Info, FID #8), Table 47, the event_idx word of an event info entry
only uses BIT[0:19]; BIT[20:31] are reserved for the future purpose
and must be zero. Table 48 further requires the SBI implementation to
return SBI_ERR_INVALID_PARAM if any reserved bit in an event_idx word
is set.
sbi_pmu_event_get_info() does not check the reserved bits, so a
malformed event_idx is silently passed on to pmu_event_validate()
instead of failing the call. Add SBI_PMU_EVENT_IDX_MBZ_MASK covering
the must-be-zero bits and return SBI_ERR_INVALID_PARAM when any of
them are set.
Fixes: e4345842168b ("lib: sbi_pmu: Implement SBI PMU event info function")
Signed-off-by: David E. Garcia Porras <david.garcia@aheadcomputing.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20260818210023.466462-2-david.garcia@aheadcomputing.com
Signed-off-by: Anup Patel <anup@brainfault.org>
Diffstat (limited to 'lib/sbi/sbi_pmu.c')
| -rw-r--r-- | lib/sbi/sbi_pmu.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/sbi/sbi_pmu.c b/lib/sbi/sbi_pmu.c index a0f6d2fa..4558876e 100644 --- a/lib/sbi/sbi_pmu.c +++ b/lib/sbi/sbi_pmu.c @@ -1098,6 +1098,9 @@ int sbi_pmu_event_get_info(unsigned long shmem_phys_lo, unsigned long shmem_phys einfo = (struct sbi_pmu_event_info *)(shmem_phys_lo); for (i = 0; i < num_events; i++) { event_idx = einfo[i].event_idx; + /* Any must-be-zero event_idx bits set should return INVALID_PARAM per-spec */ + if (event_idx & SBI_PMU_EVENT_IDX_MBZ_MASK) + return SBI_ERR_INVALID_PARAM; event_type = pmu_event_validate(phs, event_idx, einfo[i].event_data); if (event_type < 0) { einfo[i].output = 0; |